[webkit-reviews] review requested: [Bug 32462] build-webkit: Add --inspector-frontend flag to copy inspector front-end changes to the built framework : [Attachment 44742] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Dec 12 13:31:50 PST 2009


Daniel Bates <dbates at webkit.org> has asked  for review:
Bug 32462: build-webkit: Add --inspector-frontend flag to copy inspector
front-end changes to the built framework
https://bugs.webkit.org/show_bug.cgi?id=32462

Attachment 44742: Patch
https://bugs.webkit.org/attachment.cgi?id=44742&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
Minor stylistic change. Changed ordering of variables $sourceInspectorPath and
$inspectorResourcesDirPath in subroutine copyInspectorFrontendFiles.

Spoke to Timothy on IRC, and this patch should be sufficient to land. That is,
the assumptions for the Qt and GTK builds are not unreasonable. Optionally, the
user can set the environment variable WebKitInspectorResourcesDir to specify
where the built inspector front-end files are located.


More information about the webkit-reviews mailing list