[webkit-reviews] review requested: [Bug 32466] Performance problems with index validation code for drawElements : [Attachment 44734] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 32466: Performance problems with index validation code for drawElements
https://bugs.webkit.org/show_bug.cgi?id=32466

Attachment 44734: Patch
https://bugs.webkit.org/attachment.cgi?id=44734&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Added a cache of the maximum index for each element type to WebGLBuffer,
querying it before iterating through the indices in the client-side copy of the
buffer's data. Hoisted checks of the size of the element array itself into
validateElementArraySize to avoid duplicating code.

Because this is a performance fix I wasn't able to write a layout test for it.
A manual test, manual-tests/webgl/ManyPlanetsDeepHiRes.html, was added which
runs 50% faster after this fix. All previous layout tests for out-of-range
indices continue to pass.