[webkit-reviews] review granted: [Bug 32383] Selecting article text at sfgate.com results in spurious back/forward entries : [Attachment 44715] Much simpler rule, much simpler patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 11 16:20:55 PST 2009
Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 32383: Selecting article text at sfgate.com results in spurious
back/forward entries
https://bugs.webkit.org/show_bug.cgi?id=32383
Attachment 44715: Much simpler rule, much simpler patch
https://bugs.webkit.org/attachment.cgi?id=44715&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Brady and I discussed some refinements:
1) Using an enum instead of a boolean.
2) Reducing the number of arguments to the public versions at least, of the
submit function on HTMLFormElement.
I think this is OK to land as-is, but if you want to change to an enum that's
cool too.
r=me
More information about the webkit-reviews
mailing list