[webkit-reviews] review granted: [Bug 32326] Refactor some security code out of V8 bindings : [Attachment 44709] Adds newlines and a BindingSecurityBase class

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 15:12:59 PST 2009


Adam Barth <abarth at webkit.org> has granted Charles Reis <creis at chromium.org>'s
request for review:
Bug 32326: Refactor some security code out of V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=32326

Attachment 44709: Adds newlines and a BindingSecurityBase class
https://bugs.webkit.org/attachment.cgi?id=44709&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  I'm going to wait a bit before landing this in case someone
else wants to give their opinion.

+ DEFINE_STATIC_LOCAL(State, globalV8BindingState, ());

I'm surprised that compiles without the template paramater, but if it does
that's fine.  :)


More information about the webkit-reviews mailing list