[webkit-reviews] review denied: [Bug 32398] [Chromium] Expose SecurityOrigin::shouldHideReferrer() in chromium port api. : [Attachment 44695] patch2

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 32398: [Chromium] Expose SecurityOrigin::shouldHideReferrer() in chromium
port api.
https://bugs.webkit.org/show_bug.cgi?id=32398

Attachment 44695: patch2
https://bugs.webkit.org/attachment.cgi?id=44695&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebKit/chromium/public/WebSecurityOrigin.h
...
> +    // Returns whether the url should be allowed to see the referrer
> +    // based on their respective protocols.
> +    WEBKIT_API static bool shouldHideReferrer(const WebURL& url, const
WebString& referrer);

Even though WebCore uses String for referrer, please use a WebURL here
because it is in fact supposed to be an URL.  The WebKit API tries to
use WebURL everywhere it is true that a parameter is an URL.