[webkit-reviews] review granted: [Bug 32399] Pan Scrolling Jumps out of frames if the initial location is in a frame that can't be scrolled : [Attachment 44698] [PATCH] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 11:31:23 PST 2009


Darin Adler <darin at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 32399: Pan Scrolling Jumps out of frames if the initial location is in a
frame that can't be scrolled
https://bugs.webkit.org/show_bug.cgi?id=32399

Attachment 44698: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=44698&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This looks OK and probably fixes this bug. But the existing logic doesn’t seem
exactly right to me. A renderer can be an element with fixed positioning, in
which case it doesn't make sense to advance to its parent when deciding what to
scroll.

r=me


More information about the webkit-reviews mailing list