[webkit-reviews] review requested: [Bug 32326] Refactor some security code out of V8 bindings : [Attachment 44696] Update BindingSecurity class to use templates
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 11 10:51:08 PST 2009
Charles Reis <creis at chromium.org> has asked for review:
Bug 32326: Refactor some security code out of V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=32326
Attachment 44696: Update BindingSecurity class to use templates
https://bugs.webkit.org/attachment.cgi?id=44696&action=review
------- Additional Comments from Charles Reis <creis at chromium.org>
This updated patch makes BindingSecurity a template class so that each binding
will be able to implement things it depends on, like execution state, without
needing virtual methods. I threw in a few typedefs to make the code easier to
use at the call sites.
I also made the error reporting function visible outside V8Proxy.cpp so that we
can call it.
Thoughts?
More information about the webkit-reviews
mailing list