[webkit-reviews] review granted: [Bug 32436] [check-webkit-style] False positive for tst_QWebFrame : [Attachment 44693] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 10:00:02 PST 2009

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32436: [check-webkit-style] False positive for tst_QWebFrame

Attachment 44693: Patch

------- Additional Comments from Eric Seidel <eric at webkit.org>
It wasn't initially clear to me from the ChangeLog or the change that this was
related to function names.  Perhaps the changelog text could be improved.

You might also note that tst_ is a required name for the Qt unit testing system
(I assume it's required?) because if it's optional it's not a very good name.

More information about the webkit-reviews mailing list