[webkit-reviews] review granted: [Bug 32429] Add capability for ChromeClient implementations to refer 'accept' attribute value of an INPUT element : [Attachment 44685] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Dec 11 09:25:34 PST 2009
Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 32429: Add capability for ChromeClient implementations to refer 'accept'
attribute value of an INPUT element
https://bugs.webkit.org/show_bug.cgi?id=32429
Attachment 44685: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=44685&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebCore/rendering/RenderFileUploadControl.cpp
...
> +String RenderFileUploadControl::acceptTypes()
> +{
> + HTMLInputElement* input = static_cast<HTMLInputElement*>(node());
> + return input->accept();
> +}
nit: no need for the input variable, just do:
return static_cast<HTMLInputElement*>(node())->accept();
Otherwise, R=me
More information about the webkit-reviews
mailing list