[webkit-reviews] review canceled: [Bug 32430] [v8, dom] Add a pointer field to C++ Node class : [Attachment 44687] Forgotten ChangeLog update

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 11 08:41:25 PST 2009


anton muhin <antonm at chromium.org> has canceled anton muhin
<antonm at chromium.org>'s request for review:
Bug 32430: [v8, dom] Add a pointer field to C++ Node class
https://bugs.webkit.org/show_bug.cgi?id=32430

Attachment 44687: Forgotten ChangeLog update
https://bugs.webkit.org/attachment.cgi?id=44687&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Dmitry Glazkov suggested to rework in a ways more maintainable fashion.

My current plan is to introduce ScriptWrappable class and inherit Node from it
(in the vain of ScriptValue).  JSC implementation would be just an empty class,
while V8 implementation would hold a pointer to proper type.

If anyone has any additional concerns I should address before asking for
review, please, update the bug.


More information about the webkit-reviews mailing list