[webkit-reviews] review granted: [Bug 32428] [Qt] ImageDecoderQt fails to provide image file extensions : [Attachment 44680] Retrieve the format immediately after creating the QImageReader

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Andreas Kling
<andreas.kling at nokia.com>'s request for review:
Bug 32428: [Qt] ImageDecoderQt fails to provide image file extensions
https://bugs.webkit.org/show_bug.cgi?id=32428

Attachment 44680: Retrieve the format immediately after creating the
QImageReader
https://bugs.webkit.org/attachment.cgi?id=44680&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

Holger, would be great if you could double-check it, too. But from all I can
see this seems like a safe thing to do. Calling format() will only initialize
the handler (which we need to do anyway), but otherwise retrieving the format
doesn't trigger any of the expensive decoding work.

We _could_ also do the initHandler() part on demand. But right now this patch
seems safe and it fixes a failing assertion (crash) in the DragController when
dragging images. (the assertion being that the format must be non-empty)