[webkit-reviews] review granted: [Bug 32165] WebSocket errors should be logged to console : [Attachment 44645] Log WebSocket error to Web Inspector console.

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32165: WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=32165

Attachment 44645: Log WebSocket error to Web Inspector console.
https://bugs.webkit.org/attachment.cgi?id=44645&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
nits: "WebSocket-Origin not found" and "WebSocket-Location not found" should
use same pattern as "No response code found". Also "origin found" and "location
found" might sound like the corresponding urls could not be resolved, while in
your case you want to say that they are missing in headers. Consider reporting
something more concrete like "Error during WebSocket handshake:
'websocket-origin' header is missing". Same for location.