[webkit-reviews] review denied: [Bug 32391] Don't allow default framebuffer to be mutated : [Attachment 44658] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 10 20:19:34 PST 2009

Oliver Hunt <oliver at apple.com> has denied Kenneth Russell <kbr at google.com>'s
request for review:
Bug 32391: Don't allow default framebuffer to be mutated

Attachment 44658: Proposed patch

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think that active fbo should be tracked in the WebGLRenderingContext rather
than the lower level -- in general the design of the graphics contexts is
intended to minimise low level checking and instead have the DOM binding
perform checks (eg. we assume webcore internally uses GraphicsContext3D in a
safe way -- the DOM API assumes that web developers aren't)

This has the benefit of allowing all implementations to share the same guard
logic implementation as well.

In all honesty I currently believe that too much of the validation is performed
in the GraphicsContext3D implementations and intend to fix that at some point
-- we basically want GraphicsContext3D to be a C++ object wrapping the
appropriate system libraries with very little (if any) validation.


More information about the webkit-reviews mailing list