[webkit-reviews] review granted: [Bug 32386] [V8] Events created in isolated worlds may fire in main world : [Attachment 44634] Fix isolated worlds event story

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 10 13:19:47 PST 2009


Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 32386: [V8] Events created in isolated worlds may fire in main world
https://bugs.webkit.org/show_bug.cgi?id=32386

Attachment 44634: Fix isolated worlds event story
https://bugs.webkit.org/attachment.cgi?id=44634&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Dimitri explained this to me over chat:

me: there are really three contexts
1) the main world
2) the current world when we contruct
3) the current world when we retrieve

Dimitri: yah!
you said if betterer than I could.

me: i see, we only care about (3) as an optimization to avoid holding handles

===

LGTM once you fix the stylebot nit and the param names.  Thanks so much for
working on this.


More information about the webkit-reviews mailing list