[webkit-reviews] review granted: [Bug 32389] [v8] refactor WeakReferenceMap : [Attachment 44633] first take
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 10 12:46:29 PST 2009
Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 32389: [v8] refactor WeakReferenceMap
https://bugs.webkit.org/show_bug.cgi?id=32389
Attachment 44633: first take
https://bugs.webkit.org/attachment.cgi?id=44633&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Wow, this looks great. I didn't consider using the visitor interface
internally, but it makes for some prettier code.
+ virtual bool removeIfPresent
+ virtual void clear
Do these need to be virtual? It doesn't look like they need to be overridden.
More information about the webkit-reviews
mailing list