[webkit-reviews] review granted: [Bug 31738] Web Inspector: Console Scope Bar should be on top of console when Console is a Panel : [Attachment 44577] [PATCH] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 10 10:25:11 PST 2009


Pavel Feldman <pfeldman at chromium.org> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 31738: Web Inspector: Console Scope Bar should be on top of console when
Console is a Panel
https://bugs.webkit.org/show_bug.cgi?id=31738

Attachment 44577: [PATCH] Fix
https://bugs.webkit.org/attachment.cgi?id=44577&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +	   // Update styles, and give coneole-messages a top margin so it
doesn't overwrite the scope bar.

coneole-messages -> console-messages

> +	   scopeBar.addStyleClass("console-filter-top");
> +	   document.getElementById("console-messages").style.marginTop =
"23px";

xenon usually wants numbers to be a part of css


More information about the webkit-reviews mailing list