[webkit-reviews] review requested: [Bug 32099] Must fabricate GL errors instead of throwing exceptions : [Attachment 44597] Revised patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 32099: Must fabricate GL errors instead of throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=32099

Attachment 44597: Revised patch
https://bugs.webkit.org/attachment.cgi?id=44597&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
(The ChangeLogs have been updated to reflect the comments below.)

Compared to the previous version:

 - Further testing uncovered bugs in error reporting in getActiveAttrib and
getActiveUniform. These and the other bugs above highlighted the need to move
the synthetic error management down into the GraphicsContext3D, because only at
that level is complete information available for certain cases. Did this and
changed the code in WebGLRenderingContext to call
GraphicsContext3D::synthesizeGLError.
 - Testing on Chrome uncovered preexisting bugs in both WebKit's and Chrome's
implementations of bindFramebuffer, framebufferRenderbuffer, and
framebufferTexture2D. Fixed these bugs and the associated tests from
LayoutTests/fast/canvas/webgl/null-object-behaviour.html.
 - Added LayoutTests/fast/canvas/webgl/error-reporting.html, which includes
requested test cases as well as explicit regression tests for the other bugs
uncovered during this exercise.

Tested on both WebKit and Chrome. All tests now pass in both browsers; the
error reporting behavior is identical.