[webkit-reviews] review denied: [Bug 32358] Date object generates error for DD/MM/YYYY dates : [Attachment 44588] Patch to make JavaScriptCore parse DD/MM/YYYY dates correctly

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 19:50:05 PST 2009


Oliver Hunt <oliver at apple.com> has denied Estêvão Samuel Procópio
<tevaum at gmail.com>'s request for review:
Bug 32358: Date object generates error for DD/MM/YYYY dates
https://bugs.webkit.org/show_bug.cgi?id=32358

Attachment 44588: Patch to make JavaScriptCore parse DD/MM/YYYY dates correctly
https://bugs.webkit.org/attachment.cgi?id=44588&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
You need to include a testcase for this and i am concerned that will produce
incorrect behaviour for
new Date("10/11/2009")
for instance

R- for the absence of tests (although i am concerned about the behaviour i'll
wait on a testcase first)


More information about the webkit-reviews mailing list