[webkit-reviews] review requested: [Bug 32346] SVG property -webkit-shadow should apply shadow on the result after compositing : [Attachment 44589] New patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 19:16:08 PST 2009


Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 32346: SVG property -webkit-shadow should apply shadow on the result after
compositing
https://bugs.webkit.org/show_bug.cgi?id=32346

Attachment 44589: New patch
https://bugs.webkit.org/attachment.cgi?id=44589&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here's a new patch that addresses Dan's comments. I clipped the transparency
layer to the size of the shadow, but I was not able to use a single
transparency layer for both opacity and shadows. When I tried to use a single
layer, the color of the shadow (which *was* at the correct alpha level) was
visible behind the partially-transparent fill color. This seems wrong since it
is not the behavior of box-shadow.


More information about the webkit-reviews mailing list