[webkit-reviews] review requested: [Bug 31814] Inconsistent use of counterName and identifier in CSS counter code and loss of information about the counter type. : [Attachment 44587] Proposed Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 9 18:11:30 PST 2009
Carol Szabo <carol.szabo at nokia.com> has asked for review:
Bug 31814: Inconsistent use of counterName and identifier in CSS counter code
and loss of information about the counter type.
https://bugs.webkit.org/show_bug.cgi?id=31814
Attachment 44587: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=44587&action=review
------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
Added accessors and members to the CounterNode class to differentiate between
reset type nodes and nodes that act as reset because they are not in the scope
of any other counter node with the same identifier. This is useful in
reevaluating the values of counters when new counters are added to the DOM that
may make a root node non-root.
Changed references to counterName to identifier for consistency.
More information about the webkit-reviews
mailing list