[webkit-reviews] review granted: [Bug 26847] [Chromium] Delete ResourceRequest::securityInfo : [Attachment 44548] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 15:20:13 PST 2009


David Levin <levin at chromium.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 26847: [Chromium] Delete ResourceRequest::securityInfo
https://bugs.webkit.org/show_bug.cgi?id=26847

Attachment 44548: v1 patch
https://bugs.webkit.org/attachment.cgi?id=44548&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebKit/chromium/src/WebWorkerBase.cpp
> -    ResourceRequest request(url, CString());
> -    webFrame->frame()->loader()->load(request, substData, false);
> +    webFrame->frame()->loader()->load(ResourceRequest(url), substData,
false);

I suspect that gcc won't like this line (since load takes a const
ResourceRequest&) -- I seem to remember needing a variable for cases like this
when compiling with gcc.


More information about the webkit-reviews mailing list