[webkit-reviews] review granted: [Bug 32324] [Chromium] Incorrectly sends WebFrameClient notifications for a detached frame : [Attachment 44541] v1 patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 13:27:34 PST 2009


Eric Seidel <eric at webkit.org> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 32324: [Chromium] Incorrectly sends WebFrameClient notifications for a
detached frame
https://bugs.webkit.org/show_bug.cgi?id=32324

Attachment 44541: v1 patch
https://bugs.webkit.org/attachment.cgi?id=44541&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is missing a ChangeLog describing what tests this fixes.  Otherwise it
looks fine though (assuming this is covered by a test).  If it's not changing a
test, then that's bad, and I would r- this.


More information about the webkit-reviews mailing list