[webkit-reviews] review denied: [Bug 32335] [v8] in Debug builds create an additional handle scope when doing debug build checks : [Attachment 44551] first take
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 9 13:22:48 PST 2009
Adam Barth <abarth at webkit.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 32335: [v8] in Debug builds create an additional handle scope when doing
debug build checks
https://bugs.webkit.org/show_bug.cgi?id=32335
Attachment 44551: first take
https://bugs.webkit.org/attachment.cgi?id=44551&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
Seems like the ASSERTS can be outside of the #ifdef. How much does it cost to
create the handle scope unconditionally? I'd rather not have NDEBUG
everywhere.... Can we create the handle scope at a lower level where we're
already splitting on NDEBUG?
More information about the webkit-reviews
mailing list