[webkit-reviews] review granted: [Bug 32296] Implement 'select all' for WebKit/win/WebFrame : [Attachment 44497] Provide simple selectAll implementation.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 09:35:57 PST 2009


Darin Adler <darin at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 32296: Implement 'select all' for WebKit/win/WebFrame
https://bugs.webkit.org/show_bug.cgi?id=32296

Attachment 44497: Provide simple selectAll implementation.
https://bugs.webkit.org/attachment.cgi?id=44497&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (!coreFrame->editor()->command("SelectAll").execute())
> +	   return E_FAIL;

I think coreFrame->selection()->selectAll() would be better here. But this
seems OK.


More information about the webkit-reviews mailing list