[webkit-reviews] review granted: [Bug 32301] Add "using std::foo" rule checked by script to coding style guidelines : [Attachment 44509] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 09:31:44 PST 2009


Darin Adler <darin at apple.com> has granted Chris Jerdonek
<chris.jerdonek at gmail.com>'s request for review:
Bug 32301: Add "using std::foo" rule checked by script to coding style
guidelines
https://bugs.webkit.org/show_bug.cgi?id=32301

Attachment 44509: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=44509&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +<li>In header files in the WTF sub-library, however, it is acceptable
> +to use "using" declarations at the end of the file to include one
> +or more names in the WTF namespace into the global scope.

I think the use of the verb "include" here is strange. I think it should be
"add" or "import" instead.


More information about the webkit-reviews mailing list