[webkit-reviews] review denied: [Bug 32165] WebSocket errors should be logged to console : [Attachment 44508] Log WebSocket error to Web Inspector console.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 9 08:44:32 PST 2009
Pavel Feldman <pfeldman at chromium.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32165: WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=32165
Attachment 44508: Log WebSocket error to Web Inspector console.
https://bugs.webkit.org/attachment.cgi?id=44508&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> + m_context->addMessage(InspectorControllerDestination,
JSMessageSource, LogMessageType, ErrorMessageLevel, "Error in sending handshake
message.", 0, m_handshake.clientOrigin());
Why do you dump this using InspectorControllerDestinatio (not the
ConsoleDestination)? Latter would dump both into the console clients and
inspector controller.
More information about the webkit-reviews
mailing list