[webkit-reviews] review requested: [Bug 21599] [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject structs : [Attachment 44540] Updated patch with style fixes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 08:34:36 PST 2009


Martin Robinson <martin.james.robinson at gmail.com> has asked  for review:
Bug 21599: [GTK] WebKit GTK needs a wrapper for ref counted glib/gobject
structs
https://bugs.webkit.org/show_bug.cgi?id=21599

Attachment 44540: Updated patch with style fixes
https://bugs.webkit.org/attachment.cgi?id=44540&action=review

------- Additional Comments from Martin Robinson
<martin.james.robinson at gmail.com>
I've attached an updated patch with the style fixes. It also moves GRefPtr to
the JavaScriptCore/wtf/gtk directory with GOwnPtr. I started implementing the
PointerTraits approach that Eric requested, but it seemed to increase the
complexity of the patch a bit (as well as the in-memeory size). Perhaps a
namespace would be a better approach?


More information about the webkit-reviews mailing list