[webkit-reviews] review denied: [Bug 32321] ENABLE_ORIENTATION_EVENTS does not compile : [Attachment 44535] Patch to fix build.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 9 07:46:21 PST 2009

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Patrick
<phanna at email.unc.edu>'s request for review:
Bug 32321: ENABLE_ORIENTATION_EVENTS does not compile

Attachment 44535: Patch to fix build.

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
> +	   Fix the build with ENABLE_ORIENTATION_EVENTS
> +
> +	   * page/Frame.cpp:
> +	   (WebCore::Frame::sendOrientationChangeEvent):

the change is good, but please revise the patch to include a bug link in the

More information about the webkit-reviews mailing list