[webkit-reviews] review denied: [Bug 32306] [V8] Isolated world reuse failure : [Attachment 44529] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Søren Gjesse
<sgjesse at chromium.org>'s request for review:
Bug 32306: [V8] Isolated world reuse failure
https://bugs.webkit.org/show_bug.cgi?id=32306

Attachment 44529: Patch
https://bugs.webkit.org/attachment.cgi?id=44529&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
> +    if (debugId == -1) {
> +	   snprintf(buffer, sizeof(buffer), "injected");
> +    } else {
> +	   snprintf(buffer, sizeof(buffer), "injected,%d", debugId);
> +    }

no {} for single line bodies

>      targetContext->SetData(v8::String::New(buffer));
>  
>      return true;
> @@ -1378,6 +1380,8 @@ int V8Proxy::contextDebugId(v8::Handle<v
>	   return -1;
>      v8::String::AsciiValue ascii(context->GetData());
>      char* comma = strnstr(*ascii, ",", ascii.length());
> +    if (comma == NULL)
> +	   return NULL;


if (!comma)
    return 0;

>      return atoi(comma + 1);
>  }
>