[webkit-reviews] review granted: [Bug 32310] [bzt] Convert Build to use Sequence : [Attachment 44520] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 9 01:22:41 PST 2009
Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 32310: [bzt] Convert Build to use Sequence
https://bugs.webkit.org/show_bug.cgi?id=32310
Attachment 44520: Patch
https://bugs.webkit.org/attachment.cgi?id=44520&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
45 # FIXME: This class is slowing being killed and replaced with Sequencer.
StepSequence
The trailing none is unclear:
59 self._sequence.run_and_handle_errors(tool, options, None)
45 collected_options = [option for option in set(collected_options)]
call sorted()
CheckoutNeedsUpdate does not belong in this thing. :(
Needs the above tweaks before landing.
More information about the webkit-reviews
mailing list