[webkit-reviews] review requested: [Bug 32099] Must fabricate GL errors instead of throwing exceptions : [Attachment 44507] Proposed patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has asked  for review:
Bug 32099: Must fabricate GL errors instead of throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=32099

Attachment 44507: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=44507&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
Changed WebGLRenderingContext to synthesize GL errors rather than raising
JavaScript exceptions. Removed internal getError() calls after each graphics
call. Based on idea from Ilmari Heikkinen, added create3DDebugContext() to
webgl-test.js and changed the WebGL layout tests expecting error conditions to
use it. The tests required no more than 2 lines of code change each and behave
identically to how they did before. The changes to the expected.txt files are
simply the contents of the exception messages, which implicitly test the exact
GL error raised since that is part of the detail message.