[webkit-reviews] review granted: [Bug 32277] Chromium: support custom WebCore context menu items in Chromium port. : [Attachment 44486] [PATCH] Review comments addressed.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 8 14:18:11 PST 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 32277: Chromium: support custom WebCore context menu items in Chromium
port.
https://bugs.webkit.org/show_bug.cgi?id=32277

Attachment 44486: [PATCH] Review comments addressed.
https://bugs.webkit.org/attachment.cgi?id=44486&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
OK, r=me

I'm still unconvinced that we shouldn't merge WebMediaPlayerAction into
this system.

One nit:  please use the term "perform" instead of "execute" for consistency
with the performMediaPlayerAction method.


More information about the webkit-reviews mailing list