[webkit-reviews] review granted: [Bug 31325] [Android] Android port lacks Makefiles : [Attachment 43513] Patch 4 for Bug 31325

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Steve Block
<steveblock at google.com>'s request for review:
Bug 31325: [Android] Android port lacks Makefiles
https://bugs.webkit.org/show_bug.cgi?id=31325

Attachment 43513: Patch 4 for Bug 31325
https://bugs.webkit.org/attachment.cgi?id=43513&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Mostly a rubber stamp because I don't understand the build system, but it seems
useful to have make files for your port.

1) I'm surprised at the 2-clause BSD.  I thought we used 3-clause

2) I'd like to strongly encourage you to use GYP.  It's easier for every port
to use its own build system, but its a tragedy of the commons.

3) Does you build system integrate with build-webkit?  I'd encourage you to
either make build-webkit do the right thing automagically or add a --android
flag analogous to the --chromium flag.