[webkit-reviews] review denied: [Bug 32274] Fails to build on FreeBSD, IA64, and Alpha. : [Attachment 44470] proposed fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Dec 8 07:45:23 PST 2009
Darin Adler <darin at apple.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 32274: Fails to build on FreeBSD, IA64, and Alpha.
https://bugs.webkit.org/show_bug.cgi?id=32274
Attachment 44470: proposed fix
https://bugs.webkit.org/attachment.cgi?id=44470&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
> -#if PLATFORM(X86_64) && (PLATFORM(DARWIN) || PLATFORM(LINUX) ||
PLATFORM(WIN_OS))
> +#if (PLATFORM(X86_64) && PLATFORM(UNIX)) || PLATFORM(IA64) ||
PLATFORM(ALPHA) || PLATFORM(WIN_OS)
> #define WTF_USE_JSVALUE64 1
This will incorrectly define WTF_USE_JSVALUE64 on 32-bit WIN_OS builds.
More information about the webkit-reviews
mailing list