[webkit-reviews] review granted: [Bug 32260] DOMHTMLInputElement needs getter to match setAutofilled : [Attachment 44454] Patch to add isAutofilled to Mac and Windows WebKit

[bugzilla-daemon at webkit.org]

Ada Chan <adachan at apple.com> has granted John Sullivan <sullivan at apple.com>'s
request for review:
Bug 32260: DOMHTMLInputElement needs getter to match setAutofilled
https://bugs.webkit.org/show_bug.cgi?id=32260

Attachment 44454: Patch to add isAutofilled to Mac and Windows WebKit
https://bugs.webkit.org/attachment.cgi?id=44454&action=review

------- Additional Comments from Ada Chan <adachan at apple.com>

> +HRESULT STDMETHODCALLTYPE DOMHTMLInputElement::isAutofilled(
> +    /* [retval][out] */ BOOL* result)
> +{
> +    ASSERT(m_element && m_element->hasTagName(inputTag));

Maybe separate the ASSERT into two lines?


> +    HTMLInputElement* inputElement =
static_cast<HTMLInputElement*>(m_element);
> +    *result = inputElement->isAutofilled() ? TRUE : FALSE;
> +    return S_OK;
> +}
> +

r=me