[webkit-reviews] review denied: [Bug 32251] To avoid potential crash in Android history item : [Attachment 44436] proposed patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Grace Kloba <klobag at gmail.com>'s
request for review:
Bug 32251: To avoid potential crash in Android history item
https://bugs.webkit.org/show_bug.cgi?id=32251

Attachment 44436: proposed patch
https://bugs.webkit.org/attachment.cgi?id=44436&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The tab in AndroidWebHistoryBridge.h will prevent this from being landed as is.


Although WebKit has no explicit wrapping rule, it mgiht make sense to wrap the
txt in the ChangeLog at some point.

It feels strange that HistoryItem.cpp has to have an ANDROID ifdef, but maybe
that's the design that you and Brady agreed on?

r- for the tab.