[webkit-reviews] review denied: [Bug 32248] [Chromium]: Issue with setting selection : [Attachment 44435] Fix for Chromium issue http://crbug.com/27910

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Finnur
Thorarinsson <finnur.webkit at gmail.com>'s request for review:
Bug 32248: [Chromium]: Issue with setting selection
https://bugs.webkit.org/show_bug.cgi?id=32248

Attachment 44435: Fix for Chromium issue http://crbug.com/27910
https://bugs.webkit.org/attachment.cgi?id=44435&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Since the WebKit bug links to the Chromium bug, I think it is
sufficient to just include the WebKit bug link in the ChangeLog.


> Index: WebKit/chromium/src/WebFrameImpl.cpp
...
>	   if (node && node != frame()->document()) {
>	       // Found a focusable parent node. Set focus to it.
>	       frame()->document()->setFocusedNode(node);
> +	       return;
>	   } else {

nit: now that have the return statement, please remove the else
statement so that you can reduce the indentation of the following
code.

R=me otherwise.