[webkit-reviews] review granted: [Bug 32167] Extend ResourceRequest::TargetType to be more specific : [Attachment 44415] Patch addressing Darin's comments.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 7 10:32:48 PST 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Mike Belshe
<mike at belshe.com>'s request for review:
Bug 32167: Extend ResourceRequest::TargetType to be more specific
https://bugs.webkit.org/show_bug.cgi?id=32167

Attachment 44415: Patch addressing Darin's comments.
https://bugs.webkit.org/attachment.cgi?id=44415&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/platform/network/ResourceRequestBase.h
...
> +	   enum TargetType {
> +	       TargetIsMainFrame,
> +	       TargetIsSubFrame,
> +	       TargetIsSubResource,  // Resource is a generic subresource. 
(Generally a specific type should be specified)

Sorry to over nit, but just for completeness my suggestion was to only keep the

comment in parenthesis since the "Resource is a generic subresource" is a bit
redundant with TargetIsSubResource.  So, just this:

  TargetIsSubResource,	// Generally a specific type should be specified
instead.

R=me


More information about the webkit-reviews mailing list