[webkit-reviews] review granted: [Bug 32144] Add test for WebSocket.url attribute : [Attachment 44371] Fragments now make WebSocket URL parsing fail.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 7 10:32:11 PST 2009
Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32144: Add test for WebSocket.url attribute
https://bugs.webkit.org/show_bug.cgi?id=32144
Attachment 44371: Fragments now make WebSocket URL parsing fail.
https://bugs.webkit.org/attachment.cgi?id=44371&action=review
------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
// The spec says that the string passed to WebScoket constructor should be
returned unchanged.
This is no longer so; this comment should be removed.
+shouldThrow('new WebSocket("ws://127.0.0.1/path#fragment")');
Please test empty fragment, too.
r=me with these modifications.
More information about the webkit-reviews
mailing list