[webkit-reviews] review denied: [Bug 24300] Add CSSKeepVisitedLinksPrivate option to WebCore : [Attachment 44364] Update to skip test for Mac

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied robert <robert at roberthogan.net>'s
request for review:
Bug 24300: Add CSSKeepVisitedLinksPrivate option to WebCore
https://bugs.webkit.org/show_bug.cgi?id=24300

Attachment 44364: Update to skip test for Mac
https://bugs.webkit.org/attachment.cgi?id=44364&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> @@ -873,7 +873,11 @@
CSSStyleSelector::SelectorChecker::SelectorChecker(Document* document, bool
stri
>      , m_collectRulesOnly(false)
>      , m_pseudoStyle(NOPSEUDO)
>      , m_documentIsHTML(document->isHTMLDocument())
> +    , m_cssVisitedStyleEnabled(true)

In a class named CSSStyleSelector, it seems that include "css" in the name of
the data member is not helpful. The best boolean data member names are things
that complete a phrase "style selector <xxx>" so I would call this
m_ignoresVisitedLinks.

I'm also not sure the CSS style selector is the right level for this. The
PageGroup class already has a function setShouldTrackVisitedLinks. Do we really
need to add something else?

I'm going to say review- for now so you can consider both of those comments.