[webkit-reviews] review denied: [Bug 32121] [Qt] implement ImageDecoderQt::clearFrameBufferCache() : [Attachment 44250] fix style violations.

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 32121: [Qt] implement ImageDecoderQt::clearFrameBufferCache()
https://bugs.webkit.org/show_bug.cgi?id=32121

Attachment 44250: fix style violations.
https://bugs.webkit.org/attachment.cgi?id=44250&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> Index: WebCore/platform/graphics/qt/ImageDecoderQt.cpp
> ===================================================================
> --- WebCore/platform/graphics/qt/ImageDecoderQt.cpp	(revision 51636)
> +++ WebCore/platform/graphics/qt/ImageDecoderQt.cpp	(working cop
> -void ImageDecoderQt::clearFrameBufferCache(size_t /*index*/)
> +void ImageDecoderQt::clearFrameBufferCache(size_t index)
>  {
> +    if (index >= m_frameBufferCache.size())
> +	   return;

I think this should be >...as of the semantic of clearFrameBufferCache..



> +    // create the image reader object again
> +    if (!m_reader)
> +	   m_reader = new QImageReader(m_buffer, m_format);

m_buffer is deleted here...compare with ::FailRead and internalReadImage...



You should move the deletion and creation of m_reader, m_buffer into a common
method.