[webkit-reviews] review requested: [Bug 32024] [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER : [Attachment 44345] patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk-2

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung at gmail.com> has asked  for review:
Bug 32024: [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=32024

Attachment 44345: patch for the build error when JAVASCRIPT_DEBUGGER is
disabled on gtk-2
https://bugs.webkit.org/attachment.cgi?id=44345&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung at gmail.com>
I add '-DENABLE_JAVASCRIPT_DEBUGGER 0' to WebCore/GNUmakefile.am as below,  
===========================================================
if ENABLE_JAVASCRIPT_DEBUGGER
FEATURE_DEFINES_JAVASCRIPT += ENABLE_JAVASCRIPT_DEBUGGER=1

webcore_cppflags += \
	-DENABLE_JAVASCRIPT_DEBUGGER=1

else
webcore_cppflags += \
	-DENABLE_JAVASCRIPT_DEBUGGER=0

endif # END ENABLE_JAVASCRIPT_DEBUGGER
===========================================================

I find that some features ,for example ENABLE_DATABASE, ENABLE_ICONDATABASE,
ENABLE_WEB_SOCKETS, already use this way.