[webkit-reviews] review denied: [Bug 32176] Test that an image's size is valid before reading it. : [Attachment 44338] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 32176: Test that an image's size is valid before reading it.
https://bugs.webkit.org/show_bug.cgi?id=32176

Attachment 44338: patch
https://bugs.webkit.org/attachment.cgi?id=44338&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
>      // Zero-height images can cause problems for some ports.  If we have an
>      // empty image dimension, just bail.
> -    if (size().isEmpty())
> +    if (isSizeAvailable() && size().isEmpty())
>	   return 0;

This changes the logic. If the size is not available, this now continues and
creates a native image. But the old code would return 0 if the size was not
available. You should reverse the logic.

    if (!isSizeAvailable() || ...