[webkit-reviews] review denied: [Bug 32059] [Qt] Plugins: Force windowless mode when there is no native window handle : [Attachment 44136] Inject wmode=opaque

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 15:12:39 PST 2009


Simon Hausmann <hausmann at webkit.org> has denied Girish Ramakrishnan
<girish at forwardbias.in>'s request for review:
Bug 32059: [Qt] Plugins: Force windowless mode when there is no native window
handle
https://bugs.webkit.org/show_bug.cgi?id=32059

Attachment 44136: Inject wmode=opaque
https://bugs.webkit.org/attachment.cgi?id=44136&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I agree with the approach, but I have two comments about the implementation:

1) The proposed patch appends the wmode parameter. Are you sure that flash will
always use the last wmode parameter if it's specified? Wouldn't it be better to
_replace_ the value of an existing wmode if specified and only otherwise
append?

2) I think this kind of quirk doesn't belong into PluginView.cpp but rather
into FrameLoaderClientQt::createPlugin. IMHO it's much more specific to the
needs of Qt (with its QGraphicsView) than to the implementation of the spec or
the needs of the other ports.


More information about the webkit-reviews mailing list