[webkit-reviews] review granted: [Bug 32168] [Qt] Add setAllowUniversalAccessFromFileURLs to the LayoutTestController : [Attachment 44326] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth at webkit.org>'s request for review:
Bug 32168: [Qt] Add setAllowUniversalAccessFromFileURLs to the
LayoutTestController
https://bugs.webkit.org/show_bug.cgi?id=32168

Attachment 44326: Patch
https://bugs.webkit.org/attachment.cgi?id=44326&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK.  I'm surprised that:
+   
m_drt->webPage()->settings()->setAttribute(QWebSettings::LocalContentCanAccessR
emoteUrls, enabled);

uses a different way to get to settings than:
    
m_topLoadingFrame->page()->settings()->setAttribute(QWebSettings::DeveloperExtr
asEnabled, true);