[webkit-reviews] review granted: [Bug 32055] Add test for cross-origin WebSocket usage : [Attachment 44287] Add tests for cross-origin WebSocket usage

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 13:33:11 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 32055: Add test for cross-origin WebSocket usage
https://bugs.webkit.org/show_bug.cgi?id=32055

Attachment 44287: Add tests for cross-origin WebSocket usage
https://bugs.webkit.org/attachment.cgi?id=44287&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Looks good, r=me.

One general note: it would be nice if parts of _wsh.py scripts' functionality
could be shared between tests. We could use URL queries to pass parameters to
them.

Of course, combining them all into one script should not be a goal, but
reducing the number of files necessary for an average test would be good.


More information about the webkit-reviews mailing list