[webkit-reviews] review denied: [Bug 30210] [Cache] Add embedded profile to prune decoded resources more early : [Attachment 41475] Add proof of concept for the approach.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 13:02:08 PST 2009


Adam Barth <abarth at webkit.org> has denied Holger Freyther <zecke at selfish.org>'s
request for review:
Bug 30210: [Cache] Add embedded profile to prune decoded resources more early
https://bugs.webkit.org/show_bug.cgi?id=30210

Attachment 41475: Add proof of concept for the approach.
https://bugs.webkit.org/attachment.cgi?id=41475&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please fix the style issues.  Also, please use a const bool instead of
EMBEDDED_PROFILE_CHECK.  This code

+ if (EMBEDDED_PROFILE_CHECK elapsedTime < cMinDelayBeforeLiveDecodedPrune)

looks super wonky.  The compiler will optimize const bools properly.


More information about the webkit-reviews mailing list