[webkit-reviews] review granted: [Bug 31390] Implement run-webkit-websocketserver : [Attachment 44289] Add run-webkit-websocketserver

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 31390: Implement run-webkit-websocketserver
https://bugs.webkit.org/show_bug.cgi?id=31390

Attachment 44289: Add run-webkit-websocketserver
https://bugs.webkit.org/attachment.cgi?id=44289&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Thanks for updating the patch!

> +# Note: This script must be run from WebKit directory.

I don't think that there is a good reason for this limitation. Why not use
webkitdirs.pm to make it work from any directory, like all our scripts do?

> +    # wss is disabled until all platforms support pyOpenSSL.
> +    # close WEBSOCKETSECURESERVER_IN;
> +    # close WEBSOCKETSECURESERVER_OUT;
> +    # close WEBSOCKETSECURESERVER_ERR;
> +    # kill 15, $webSocketSecureServerPID;

This needs to be removed prior to landing.

> +    $isWebSocketServerOpen = 0;

Tracking the state seems superfluous - there is no way for
openWebSocketServerIfNeeded to be called twice in this script, and no way for
it to be called after closing.

r=me, but please fix the script to work from any directory. And this patch
cannot be landed by commit-queue, because commented out code needs to be
removed.