[webkit-reviews] review denied: [Bug 29912] Avoid zero division during SVGPaintServerPattern::setup() : [Attachment 40344] Proposed fix for a Chromium SVG crash

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 11:13:53 PST 2009


Dirk Schulze <krit at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 29912: Avoid zero division during SVGPaintServerPattern::setup()
https://bugs.webkit.org/show_bug.cgi?id=29912

Attachment 40344: Proposed fix for a Chromium SVG crash
https://bugs.webkit.org/attachment.cgi?id=40344&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
The patch looks great.

> Index: WebCore/ChangeLog
...
> +
> +	   Fix a Chromium SVG crash when visiting
> +	  
http://upload.wikimedia.org/wikipedia/commons/c/c2/World_map_pol_2005_v02.svg
> +	   as reported by
> +	   http://crbug.com/14521
> +
> +	   The issue is tileRect is not empty with Skia when tileWidth or
tileHeight becomes
> +	   zero, and the calculation of numY or numX causes a zero division.
> +
> +	   * svg/graphics/SVGPaintServerPattern.cpp:
> +	   (WebCore::SVGPaintServerPattern::setup):

The discription doesn't adress the main problem: the zero division in
SVGPaintServerPattern. I don't see a connection between the fix, the problem
and the comment about Skia. Please add the topic of the bug and the link to the
bug report at the beginning of the Changelog.

r- for the Changelog.


More information about the webkit-reviews mailing list