[webkit-reviews] review granted: [Bug 32149] [Qt] Doing right-click/Reload on a QWebInspector widget will close the widget : [Attachment 44301] QtLauncher: add a menu to show/hide the inspector

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Jocelyn Turcotte
<jocelyn.turcotte at nokia.com>'s request for review:
Bug 32149: [Qt] Doing right-click/Reload on a QWebInspector widget will close
the widget
https://bugs.webkit.org/show_bug.cgi?id=32149

Attachment 44301: QtLauncher: add a menu to show/hide the inspector
https://bugs.webkit.org/attachment.cgi?id=44301&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>

> +    WebInspector(QWidget* parent) : QWebInspector(parent) {}
> +signals:
> +    void visibilityChanged(bool nowVisible);

Qt already has a visibleChanged (slightly different name) for the
QGraphicsObjects. Maybe we should use the same naming?


> +	   QAction *showInspectorAction = toolsMenu->addAction("Show
inspector", inspector, SLOT(setVisible(bool)));
> +	   showInspectorAction->setCheckable(true);
> +	  
showInspectorAction->setShortcuts(QList<QKeySequence>()<<QKeySequence(tr("F12")
));

I guess I would prefer spaces before and after the <<

But in general it LGTM. If you find it needed, make these changes before you
commit.